Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usability enhancements #2

Merged
merged 27 commits into from
Mar 26, 2024
Merged

Usability enhancements #2

merged 27 commits into from
Mar 26, 2024
+638 −295

Conversation

GitHK
Copy link
Collaborator

@GitHK GitHK commented Mar 26, 2024 •
edited
Loading

  • added extensive README.md
  • added testing for python 3.6+
  • typing is compatible with python 3.6+
  • added Prometheus metrics for network usage
  • using env vars for configuration
  • added tests to ensure configuration between activity.py and activity_monitor.py does not diverge

@GitHK GitHK self-assigned this Mar 26, 2024
@GitHK GitHK requested a review from mguidon March 26, 2024 13:51
@GitHK GitHK marked this pull request as ready for review March 26, 2024 13:52
@GitHK GitHK requested a review from elisabettai March 26, 2024 13:59
mguidon
mguidon approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will test this with the rocket

@GitHK
Copy link
Collaborator Author

GitHK commented Mar 26, 2024

I will publish this so I can release a new version. Please open issues if you require changes.

@GitHK GitHK merged commit 2e1fcb6 into main Mar 26, 2024
7 checks passed
@GitHK GitHK deleted the enhancements branch March 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguidon mguidon mguidon approved these changes

@elisabettai elisabettai Awaiting requested review from elisabettai

Assignees

@GitHK GitHK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GitHK @mguidon